Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Upgrade logic for new Metamask or implement patch #452

Closed
julianmrodri opened this issue Nov 5, 2020 · 1 comment · Fixed by #455
Closed

Upgrade logic for new Metamask or implement patch #452

julianmrodri opened this issue Nov 5, 2020 · 1 comment · Fixed by #455
Labels
difficulty: easy enhancement New feature or request P1 - High

Comments

@julianmrodri
Copy link
Contributor

On Nov 16, MetaMask will stop injecting window.web3 and make a limited number of breaking changes to our window.ethereum API. We need to implement the migration guide. There is a workaround patch that can be useful for initial release. (@metamask/legacy-web3)

https://docs.metamask.io/guide/provider-migration.html

We have to be careful to keep supporting Nifty wallet if we implement this change.
@itofarina itofarina mentioned this issue Nov 5, 2020
Closed
@itofarina
Copy link
Contributor

Should be tackled in https://github.com/rsksmart/rif-ui
Just opened this issue rsksmart/rif-ui#184
I think we could keep this issue opened until we integrate that new rif-ui version

@itofarina itofarina mentioned this issue Nov 5, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
difficulty: easy enhancement New feature or request P1 - High
Projects
None yet
Milestone
No milestone
2 participants
@itofarina @julianmrodri