Get Diagnostic Line Number

[suptejas]

So I was wondering if there way any way to get the line number of the error (which line the error occured in).

Nodejs shows you the error like so:

So i was wondering if there was any field in Diagnostic that gives you the line number.

[Stupremee]

The structure of a Diagnostic is really different. Not just a message, line combination. It consists of multiple SubDiagnostics, which are each rendered separately to allow such nice error messages. The best way to get the line is using the primary field

[suptejas]

@Stupremee so what field should I access? primary.?

[suptejas]

Or do I have to manually calculate line number?

[Stupremee]

Yes most likely. Depending on the suggestion and what line number do you want.

[Stupremee]

If you see an error message with an error, and help / info stuff, then there are multiple child diagnostics

[suptejas]

@Stupremee isn't this an essential diagnostic field however? Wouldn't you think it's hard to manually calculate?

[suptejas]

Also - not to forget, it's expensive to do this every time you need a line number - it's so much easier if we could get a line_no field so that it's less expensive

[Stupremee]

You don't need to calculate it manually. diag.primary.unwrap().span

Wait nvm. Yea you need to calculate the line number

[suptejas]

Yes, that gives me character range, not line number though 😅

[suptejas]

Also 1 more question - the primary error message i get for the first post here is correct (something along the lines of expected )), however it's not able to suggest fixes

[Stupremee]

You can take a look into rslint_errors. It's not that expensive.
First, you collect all line starts using rslint_errors::line_starts and then you can do a simple binary search on the returned list:

line_starts
  .binary_search(&byte_index)
  .unwrap_or_else(|next_line| next_line - 1),

You can even do this automatically using rslint_error::SimpleFile and the Files trait

[Stupremee]

Also 1 more question - the primary error message i get for the first post here is correct (something along the lines of expected )), however it's not able to suggest fixes

IIRC we don't suggest any fixes for any parsing errors. Might be a good addition, but is also very hard to do correctly

[suptejas]

agreed

[Stupremee]

Do you have discord or something else? Using github issues for stuff like this is annoying 😅

[suptejas]

Yes - XtremeDevX#0007