no-inner-declarations wrongfully fails on exports after the first statement

[RDambrosio016]

I tried this code:

export const foo = [];
export function bar() {}

I expected this to happen: linting passes

Instead this happened::

error[no-inner-declarations]: move this function declaration to program's root
  ┌─ tests\main.mjs:2:8
  │
2 │ export function bar() {}
  │        ^^^^^^^^^^^^^^^^^
  │
  = help: move the declaration to the program root

Meta

rslint -V: rslint 0.1.0

If building from source:
rustc --version --verbose:

rustc 1.48.0-nightly (f68e08933 2020-09-19)
binary: rustc
commit-hash: f68e08933d8f519a9655934fedebbc509661b219
commit-date: 2020-09-19
host: x86_64-pc-windows-msvc
release: 1.48.0-nightly
LLVM version: 11.0

**If
Additional context
Add any other context about the problem here.

[Stupremee]

If rslint_parse parses the file as a module, the linting passes. Because in your code (if its parsed as a script), the parent.kind() is ERROR and thus will not be counted as a valid kind. This could be easily fixed by just checking for ERROR in the lint.

[RDambrosio016]

Oh that is true, and this brings up another point, the linter should not tread into ERROR nodes, it should skip them and their children because the data inside is non-sensical

[Stupremee]

This is going to be complicated, because many lints use .parent() or .children(), which are not guaranteed to not return ERROR.

[RDambrosio016]

that does not matter if the linter does not step into the children of error nodes

[Stupremee]

Ah yes, that makes sense. Misunderstood your message

[RDambrosio016]

Although the file is .mjs so it should be parsing as module 🤔

[Stupremee]

If I rename it to .mjs and run it, the linting passes

Edit: Nvm it doesn't. 😅 Because EXPORT_DECL is not in the valid kind array.

[RDambrosio016]

haha so the issue is still there, although we caught another issue for ERROR nodes

[RDambrosio016]

Oh haha, that makes sense, its an easy fix

[RDambrosio016]

Fixed in 970df03