The linter panicked unexpectedly

[brandly]

hi! i saw your post on r/rust. i write a lot of typescript, but tried running this on some plain JS.

i ran it on this file and was told everything's good:

$ rslint_cli index.js

Outcome: 0 fail, 0 warn, 1 success

i wanted to run it on this project, but i ran into an unexpected panic.

$ rslint_cli 'src/*.js' 
error[]: The linter panicked unexpectedly. this is a bug.

We would appreciate a bug report: https://github.com/RDambrosio016/RSLint/issues/new?labels=ILE%2C+bug&template=internal-linter-error.md

note[]: Please include the following info: 

message: 
location: /Users/brandly/.cargo/registry/src/github.com-1ecc6299db9ec823/rslint_parser-0.1.2/src/parser.rs:158:9

i'm wrapping the glob in quotes because i'm on zsh, and it'll expand the glob otherwise e.g.:

$ rslint_cli src/*.js  
error: Found argument 'src/api.test.js' which wasn't expected, or isn't valid in this context

USAGE:
    rslint_cli [FLAGS] [files] [SUBCOMMAND]

For more information try --help

if i'm running this incorrectly, the feedback could be improved. otherwise, something might be broken.

thanks again. i'm looking forward to fast JS tooling.

[RDambrosio016]

Thank you for the bug report!

Im still not sure why the message is not included for that but yknow, weird rust panic info logic, but thats the parser infinitely recursing, which is usually because of:

• Bad error recovery
• Bad parsing

I will take a look and update you once i find/fix it 🙂

[RDambrosio016]

Oh nevermind, the issue is the unicode character which i did not notice, like let foo = { α: true }. The lexer makes it an error token and the parser has a hard time recovering from there. I think this is a lexer issue since if i am not mistaken that is an allowed char for identifiers

[RDambrosio016]

This also brings to light the issue of error tokens in literal properties causing infinite recursion, which is an error recovery problem. Thank you for finding 2 bugs! 😄

[RDambrosio016]

Lexer issue fixed in d0dbbe9
Parser issue has not been fixed yet

[RDambrosio016]

Fixed in 77a7ea6

[brandly]

i pulled master to the latest (f6f4cef), ran cargo install rslint_cli --force, and i still see the same thing:

$ rslint_cli 'src/*.js'
error[]: The linter panicked unexpectedly. this is a bug.

We would appreciate a bug report: https://github.com/RDambrosio016/RSLint/issues/new?labels=ILE%2C+bug&template=internal-linter-error.md

note[]: Please include the following info: 

message: 
location: /Users/brandly/.cargo/registry/src/github.com-1ecc6299db9ec823/rslint_parser-0.1.2/src/parser.rs:158:9

am i doing something wrong?

[RDambrosio016]

cargo install would be pulling from crates.io, and the fixes are on an unreleased version

[RDambrosio016]

Other than a lot of imports spam it works for me if i use cargo run

[RDambrosio016]

@brandly i published new versions, it should work now if you install again

[brandly]

thanks!

Other than a lot of imports spam it works for me if i use cargo run

you're right! this worked on my end too.

cargo install would be pulling from crates.io

i was thinking the cargo install command was just building the local package and moving it to my PATH, similar to a stack install. makes sense tho!

[RDambrosio016]

cargo install --path rslint_cli can do that