-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does rslint already support TypeScript? #87
Comments
Did you build from source? It supports TypeScript in the next version but i havent published 0.3 yet because |
I installed initially from cargo, but after that error, I tried to install from releases pages too, but apparently there is no difference between installing from cargo or prebuilt binaries from releases page |
My system is |
Yeah we publish all crates first to crates.io then add a release commit which builds binaries |
I converted my typescript file to javascript and now is working properly |
I apologize for not having published a version which could actually lint TS before putting it in the readme. If you'd like to still try it you can git clone then either cargo build a binary or cargo run and feed it a path. |
Ok, no problems. I'll wait for next publish to taste how rslint is good and close this issue after that |
I built rslint from source after running the git clone and it's working fine! |
Still waiting for a release 😅 , sometime soon would be great @RDambrosio016 |
Oh yeah. Totally forgot about a new release. I will try to do a release ASAP. |
Also, if you don't mind me asking - I'm trying to basically use rslint to validate some code, though I want to call it directly through Rust. So initially, I used: let result = rslint_parser::parse_text_lossy(read_to_string(&f).unwrap().as_str().trim(), 0); The above code worked just fine for Javascript files, though it didn't work for TS files. I then moved the crates locally and imported the raw code, instead of downloading the crate from crates.io because the latest release didn't support TS yet. The above code still doesn't look like it supports TS. What can I use to only validate syntax and stuff in TS and JS files? Which function should I use (I also want to display errors, and |
You can make a typescript |
@RDambrosio016 also was wondering, what does the |
its used for rendering errors, at the start of linting, we build a map of IDs to file data in parallel, each file stores its line indices, line starts, etc. This info is then used for rendering errors, recomputing line info for each file for each error gets slow real quick, especially when you have big files |
Right, makes sense |
TS support is now in 0.3.0 |
Hi,
I was testing
rslint
to see the difference with my eyes, but when I runrslint ***.ts
it is throwingerror: No matching files found
.This confused me because the description of this repo was saying:
After that error, I tried to lint some javascript files and it seems that there is no error.
Is this a bug or I need to do some other steps to lint typescript files?
Thanks!
The text was updated successfully, but these errors were encountered: