-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate feasibility/benefit of porting project to Typescript #14
Comments
@brandongregoryscott should be entirely feasible. Believe we would ts-node to allow us to run it without an additional transpilation step. Probably better to start this sooner rather than later. Less to port :) |
Gonna hack on this some and see how it goes |
Initial findings:
|
After discussing internally with @Stefanie899 and @brandongregoryscott we are going in the direction of housing source files in In an ideal world where transpiling typescript was trivial, we wouldn't need to output the javascript build and could just run "live" through ts-node. Development experience will be in that ideal, but publishing new versions will be output to 'lib' where end-users will use it. |
@wintondeshong I know you were hacking on this previously, I'd love to get us on typescript soon. Any thoughts on pushing up what you have and letting me wrap it up? |
Sorry for missing this @brandongregoryscott -- This has been sitting here long enough that I don't feel my branch helpful. We have a much better tuned approach for TS across our projects that starting this issue from scratch is probably easier. I'm going to unassign myself for now so others can take it on. |
No worries @wintondeshong! A lot has changed, for sure. I won't assign myself just yet, but I have been experimenting with an extended CLI and was able to get it on TS with minor hiccups over the weekend. |
Closing this as the initial port work has been completed and merged to release/2.0.0. Will report back when it has been merged down to |
Description
Investigate how much of a lift porting the project over to Typescript would be. Document any caveats or potential roadblocks, changes in development workflow, npm package publishing, etc.
The text was updated successfully, but these errors were encountered: