Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'install' command should add a new line/comment about aliases added #20

Closed
brandongregoryscott opened this issue Oct 6, 2019 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Support hacktoberfest (not required to get credit)

Comments

@brandongregoryscott
Copy link
Contributor

Description
The 'install' command should more gracefully modify the developer's .bashrc file. In my case, it did not add a new line before adding the two aliases, so one of the aliases was dropped onto the ending bracket of my .bashrc and and unexpected EOF was thrown when resourcing the file:
bash: /home/brandon/.bashrc: line 625: syntax error: unexpected end of file

}alias and-cli='npx and-cli'
alias and-cli-dev='/home/brandon/AndcultureCode.Cli/cli.js'

Additionally, a simple comment about where/why these aliases were added might be nice for someone referencing their bash file, something linking back to the repo or npm package

@brandongregoryscott brandongregoryscott added bug Something isn't working good first issue Good for newcomers hacktoberfest Support hacktoberfest (not required to get credit) labels Oct 6, 2019
@wintondeshong wintondeshong self-assigned this Oct 7, 2019
wintondeshong added a commit to wintondeshong/AndcultureCode.Cli that referenced this issue Oct 7, 2019
wintondeshong added a commit that referenced this issue Oct 7, 2019
…-bashrc

Add newlines as well as comments for cli-install to fix issue #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Support hacktoberfest (not required to get credit)
Projects
None yet
Development

No branches or pull requests

2 participants