Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared modules should no exit upon success (currently: dotnet-build) #45

Closed
wintondeshong opened this issue Jan 10, 2020 · 1 comment
Closed

Shared modules should no exit upon success (currently: dotnet-build) #45

wintondeshong opened this issue Jan 10, 2020 · 1 comment
Assignees
@brandongregoryscott
Labels
bug Something isn't working

Comments

@wintondeshong
Copy link
Contributor

wintondeshong commented Jan 10, 2020 •
edited
Loading

Problem
Currently the dotnet-build.js module will perform a shell.exit(0) (on success). The issue is that these modules are by nature to be shared. Right now this isn't being shared as a sub-step, but if it were and the parent command was hoping to do additional work after a successful build, it wouldn't occur.

Solution
Remove any shell.exit(0) in modules and leave that to the parent. At the time of writing this, the only known is the dotnet-build.js module.
@wintondeshong wintondeshong added the bug Something isn't working label Jan 10, 2020
@brandongregoryscott brandongregoryscott self-assigned this Jan 14, 2020
@wintondeshong
Copy link
Contributor Author

Merged and published in v0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandongregoryscott brandongregoryscott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wintondeshong @brandongregoryscott