Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IncludeBase, Include, and IncludeExtensions to simplify generating Include paths #4

Closed
Stefanie899 opened this issue Feb 12, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Stefanie899
Copy link
Contributor

Stefanie899 commented Feb 12, 2021

in DynamicContentExtensions.cs, the MapTo<T> function has an optional includes parameter. This is a string with multiple include paths, separated by commas, e.g. Product.Orders,Category.ParentCategory.

In order to simplify building these include paths, we should add our helper classes to this repository -- namely IncludeBase.cs, Include.cs, and IncludeExtensions.cs to more easily generate the include paths to be passed into the MapTo<T> function.

These classes are currently contained only in proprietary repos, so an andculture engineer should be contacted to get directed to the existing code.

@Stefanie899 Stefanie899 added the enhancement New feature or request label Feb 12, 2021
@brandongregoryscott
Copy link
Contributor

brandongregoryscott commented Feb 16, 2021

@Stefanie899 If possible, it would be awesome to move this to one of the non-Sitefinity repos like Core or Extensions. I think we have an open issue for it on Extensions, and there was some initial discussion on it, but no further movement. Some misunderstandings on an EF dependency (I don't believe there is one, but we should double check). Unless there's Sitefinity-specific behavior, it would be nice to have this functionality for all our projects, too.

@Stefanie899
Copy link
Contributor Author

@brandongregoryscott Good call, I think it makes sense to just live in the CSharp.Core repo. There is no dependency on EF or Sitefinity specific logic -- I built the Sitefinity code around what already existed.

I'll close this issue and move the currently open issue in Extensions to https://github.com/AndcultureCode/AndcultureCode.CSharp.Core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants