Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S0024: more than 2 digits for time offset #159

Open
emiltin opened this issue Mar 31, 2023 · 2 comments
Open

S0024: more than 2 digits for time offset #159

emiltin opened this issue Mar 31, 2023 · 2 comments
Labels

Comments

@emiltin
Copy link
Contributor

emiltin commented Mar 31, 2023

format is specified as pp-tt, which limits offset to 99 seconds. see also rsmp-nordic/rsmp_validator#227

@emiltin emiltin added the extend label Mar 31, 2023
@emiltin
Copy link
Contributor Author

emiltin commented Mar 31, 2023

would also be good to move to json arrays instead of the custom list string format

@otterdahl
Copy link
Contributor

Yes. I think the best way to solve this is to use JSon arrays. There are many statuses that suffers this issue. I'm not sure the best way to deal with this.

We could either:

  • Use a new status code, e.g S003X which uses the array and deprecate the old S0024.
  • Add a new "name" to S0024, e.g. "list" which uses array and deprecate "status"
  • Just update in place - but I wouldn't recommend that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants