Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to reset alarms #176

Open
otterdahl opened this issue Oct 4, 2023 · 9 comments
Open

Ability to reset alarms #176

otterdahl opened this issue Oct 4, 2023 · 9 comments
Labels
Milestone

Comments

@otterdahl
Copy link
Contributor

No description provided.

@emiltin
Copy link
Contributor

emiltin commented Oct 4, 2023

Would this be clearing alarms?

@otterdahl
Copy link
Contributor Author

This type of command exists in other protocols and we've gotten feedback that it is missing in RSMP.

I'm not sure if it really applies to all kinds of alarm, but the typical use case is alarms that is generated in software. For instance A0302: Detector error (logic error).

That alarm monitors that the detector has remained on or off for an unreasonable long time. It would indicate that the detector is faulty. It may use a timer to achieve this. But if the detector gets fixed, then the alarm may remain active for a long time afterwards. It would be useful to reset the alarm timer.

I don't know what the best term to use: "reset" or "clearing" alarms. I also don't know if it only applies to all alarms or only a few.

@SwarcoPalm
Copy link
Contributor

We have previously implemented this as the "restart" command (don't remember the exact name), which will reset the errors. (this also implies that if the intersection is in a major fault, it will attempt to start up again).

@emiltin
Copy link
Contributor

emiltin commented Oct 5, 2023

Resetting an alarm sounds like something you can do for a single alarm, or a set of alarms, whereas a general 'reset controller' would affect all alarms, and probably many other things as well?

@SwarcoPalm
Copy link
Contributor

Resetting single alarms is overdoing it. In some countries it's a requirement to be able to reset detector errors separately.

@Henr1O
Copy link

Henr1O commented Oct 12, 2023

The reset alarms/errors should clear all active alarms/errors on controller, simple as that. After resetting errors, the alarms will come again active, if they can't be "fixed" by resetting alarms.

Basically controllers should always clear all alarms/errors automatically, but in some cases they need manually error reset.

@Henr1O
Copy link

Henr1O commented Oct 12, 2023

As Andres wrote, Swarco controllers uses command M0004 to clear = reset alarms. This is why we need own function for clearing alarms. For example, now LS Cartesio will restart the controller with that command, but there is no command to reset alarms for example after all starting retries are used after lamp failure. Solution = let's made clear/reset errors/alarms command.

@otterdahl
Copy link
Contributor Author

Since resetting alarms needs a new command. Should we target 1.2.1 or 1.3? @emiltin

@emiltin
Copy link
Contributor

emiltin commented Jan 30, 2024

I suggest 1.3

@emiltin emiltin added this to the 1.3 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants