-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or split out rsocket-transport-aeron from rsocket-java #309
Comments
In order to use Aeron someone needs to fix the handshaking in the beginning. Basically what needs to happen is the acking that the connection is established needs to happen in the AvailableImageHandler. After the first connection subsequent connections will fail right now. |
I'm going to land this so that the code doesn't bit rot, and I'll try to find some spare time to fix this transport unless @tmontgomery beats me to it. :) |
Cool -I coded myself to a corner, and I haven't gotten around to fixing it. I should probably take a look at it again... it would be good to have someone else look at this as well. |
@robertroeser @tmontgomery I'm going to split this out into a separate project unless there is an active owner for fixing this. I consider it a blocker for a 1.0 release. Any objections? On the flipside - if one of you get it working, then I'm happy that we keep it in rsocket-java AND I'll put it as part of the automated TCK tests! |
+1 to get this issue fixed as I was motivated to use rsocket-java exactly because it has reactive streams on top of Aeron. For what it is worth, I did attempt for a few hours to provide the requested "help wanted". However, nothing really useful came out of that as I'm still a noob when it comes to the codebase of Aeron, Reactor and ReactiveSocket. I expect other newbies will have similar experiences because there is a good bunch of new concepts to process. That's just some feedback for the core developers of this library; hope it will help in making a choice with regards to the points raised by @yschimke. |
@mboogerd |
@robertroeser taking it out sounds like a good decision; and indeed, I am using the TCP one for the time being. Hopefully I will learn enough in the meantime to be more of use in resolving this issue. Thanks for your feedback! |
This was resolved by #538 |
Was "Aeron Module fails with java.lang.IndexOutOfBoundsException"
Currently disabled in settings.gradle
The text was updated successfully, but these errors were encountered: