Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragmentation & Reassembly #61

Closed
benjchristensen opened this issue Sep 23, 2015 · 6 comments
Closed

Fragmentation & Reassembly #61

benjchristensen opened this issue Sep 23, 2015 · 6 comments

Comments

@benjchristensen
Copy link
Contributor

Need to support fragmentation and reassembly.
@benjchristensen benjchristensen mentioned this issue Sep 23, 2015
Closed
@benjchristensen
Copy link
Contributor Author

We need to decide on fragmentation of requests: rsocket/rsocket#77

Right now the protocol only allows fragmenting responses.

@tmontgomery
Copy link
Contributor

REQUEST_CHANNEL can be fragmented. At least it is specified in the frame that it has an F flag. Also, the fragmenter impl should support it. Off hand, not sure about the reassembler, but it should be easy to account for.

@benjchristensen
Copy link
Contributor Author

Right, REQUEST_CHANNEL does, so it's the other 4 REQUEST types.

@tmontgomery
Copy link
Contributor

Ah ok. I will add that to the spec in the next couple days.

@tmontgomery tmontgomery self-assigned this Sep 23, 2015
@benjchristensen
Copy link
Contributor Author

Thanks Todd

@benjchristensen benjchristensen mentioned this issue Sep 23, 2015
Closed
@tmontgomery tmontgomery removed their assignment Sep 23, 2015
@benjchristensen
Copy link
Contributor Author

A possible implementation of response fragmentation and reassembly is in pull request #63

@robertroeser robertroeser mentioned this issue Apr 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjchristensen @tmontgomery @robertroeser