-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT+COMPLETE RequestResponse Efficiency #9
Comments
If the responder can package a NEXT and COMPLETE together to hand to the protocol together, then the protocol can batch them into a single frame trivially. |
Since we know by stream initiation that a particular request is request-response, do we even need a complete event. Complete is implicit upon receiving a complete data frame(s) including fragmented frames. |
@NiteshKant true. For REQUEST_RESPONSE, there is only a single NEXT. If that is the semantic, could possibly collapse it down to just a completed and reassembled NEXT. I.e. a NEXT with the END bit set. |
Implemented. |
Currently request/response requires 2 messages to complete (NEXT + COMPLETE): ;https://github.com/ReactiveSocket/reactivesocket-java/blob/e38b757ca02e597712139dfb9d01ba5dc7079c40/src/main/java/io/reactivesocket/ReactiveSocketServerProtocol.java#L105
The protocol design will support multiple headers (types) being sent in a single frame.
I'm not suggesting the network protocol needs a new type, only that we figure out the optimization in Java.
The text was updated successfully, but these errors were encountered: