Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support for LoadBalancedRSocketMono #46

Open
neilswingler opened this issue Sep 18, 2019 · 2 comments
Open

Feature request: support for LoadBalancedRSocketMono #46

neilswingler opened this issue Sep 18, 2019 · 2 comments

Comments

@neilswingler
Copy link

neilswingler commented Sep 18, 2019

It would be cool if the client stub would accept a Mono<Rsocket> in the constructor so a LoadBalancedRSocketMono could be passed in. Currently my solution is to create a new client stub instance for each request invocation which could have a noticeable memory consumption for a large number of concurrent requests.

@robertroeser
Copy link
Member

We could wrap a the load balancer with an RSocket so that you don't have to create a new:
https://gist.github.com/robertroeser/14cbadc21ef26e518fffe4ebcf0fe112

@neilswingler
Copy link
Author

neilswingler commented Oct 11, 2019

That will work without any new release I suppose. I guess you know best whether to use a Mono<RSocket> or an RSocket wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants