Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better parser error messages #129

Closed
V0ldek opened this issue Apr 28, 2023 · 2 comments · Fixed by #402
Closed

Better parser error messages #129

V0ldek opened this issue Apr 28, 2023 · 2 comments · Fixed by #402
Assignees
@V0ldek
Labels
area: app Improvements in overall CLI app usability help wanted External contributions welcome type: feature New feature or request
Milestone
v1.0.0

Comments

@V0ldek
Copy link
Member

V0ldek commented Apr 28, 2023

Is your feature request related to a problem? Please describe.
Nom has more robust error handling than we are currently using, making our errors meh. We should investigate better methods.

Describe the solution you'd like
First check if switching to nom's VerboseError won't automagically make our CLI much better.

Additional context
https://github.com/rust-bakery/nom/blob/main/doc/error_management.md
@V0ldek V0ldek added type: feature New feature or request help wanted External contributions welcome mod: parser area: app Improvements in overall CLI app usability labels Apr 28, 2023
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Apr 28, 2023
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added this to the v1.0.0 milestone May 1, 2023
@V0ldek V0ldek self-assigned this May 1, 2023
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels May 1, 2023
@V0ldek V0ldek mentioned this issue Jan 2, 2024
Merged
3 tasks
@V0ldek
Copy link
Member Author

V0ldek commented Jan 2, 2024

All error handling was rewritten in #402 and is now much prettier and more useful.

@github-actions github-actions bot removed the acceptance: go ahead Reviewed, implementation can start label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
area: app Improvements in overall CLI app usability help wanted External contributions welcome type: feature New feature or request
Projects
Active rq development
Status: Released
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Feature parity of the new parser rsonquery/rsonpath
1 participant
@V0ldek