-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable_monkey_patching url in spec helper template links to unavailable Relish documentation #3031
Comments
@JonRowe If I replace |
@pirj hi, correct, it's the same case for me. btw I have tried to open Pull Request with updates for links from RelishApp to RSpec.info around the whole repository, but while doing so I'm getting 403 error:
any ideas what's wrong with this flow? 😕 it's not clear to me after following https://github.com/rspec/rspec-core#contributing |
It's missing from the docs, but normally, you fork the repo, push the changes to your forked repo, and send a PR upstream. |
@pirj thanks, gonna try the proposed path @JonRowe |
Nice catch. Other repos, too, and |
@pirj @JonRowe I have taken the opportunity to open the issues for 'About' url updates in each of the repos that mentions Relish for consistency & track ability: |
@JonRowe if it's possible to fix rspec.info docs to work with latest in the url path and to not drop the anchor part like in the example above - I would be very happy to update all Relish related links in Please confirm if that's doable. 😉 |
@tomczak-mateusz I guess this is handled here and here if you feel adventurous enough to try fixing the missing anchor. |
Fixed in #3035 |
Remove of the link in generated content was released in 3.12.2 |
Subject of the issue
disable_monkey_patching url in spec helper template links to unavailable Relish documentation
As I have read on page: https://rspec.info/documentation/ - RSpec documentation is being moved to rspec.info from RelishApp:
I have opened this issue as it might be confusing for the fresh RSpec users to hit the unavailable link.
Your environment
Steps to reproduce
For more details, see
link: https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-modeExpected behavior
Actual behavior
The text was updated successfully, but these errors were encountered: