Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller spec: get :index throws deprecation warning on Rails 4.2.0. #1254

Closed
JuanitoFatas opened this issue Dec 23, 2014 · 2 comments
Closed

Comments

@JuanitoFatas
Copy link

Greetings,

Rails 4.2.0, Ruby 2.1.5., rspec-rails 3.1.0.

With this spec:

describe ThingsController do
  let(:user) { create(:user) }

  before { sign_in user }

  describe '#index' do
    def do_request
      get :index # <<< This line throws warning.
    end

    before { do_request }

    it { expect(response).to be_success }
  end
end

get :index throws warning:

DEPRECATION WARNING: sanitize_sql_hash_for_conditions is deprecated, and will be removed in Rails 5.0.

Thanks! 😄

@JonRowe
Copy link
Member

JonRowe commented Dec 24, 2014

Re run your specs with --backtrace to see where this is really coming from, it's unlikely it's coming from RSpec directly.

@cupakromer
Copy link
Member

I'm going to close this. There is no reference to sanitize_sql_hash_for_conditions in the rspec-rails code base. @JuanitoFatas if the full backtrace states otherwise, please feel free to re-open this issue posting the full details from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants