-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rails g rspec:install
doesn't add config.generators.test_framework
setting
#2220
Comments
I believe it's here. Can you reproduce this with |
Wow, that was fast! It appears that in order to take advantage of this, I need to |
As far as I remember, putting this in group :development, :test do
gem 'rspec-rails', '~> 4.0' # in case of pre-release '4.0.0.beta3'
end |
My goodness, you're right. I think when I tried it yesterday, maybe I hadn't run |
Okay, one thing I just noticed is that the default generators still create controller specs, even though they are discouraged as of RSpec 3.5. I ended up adding the following line to my generators.test_framework :rspec, controller_specs: false Is this something that is worthy of fixing? Is a fix already planned for it? I can think of two ways:
|
Good point. This is something that #2222 is about to address.
|
What Ruby, Rails and RSpec versions are you using?
Ruby version: 2.7.0preview1
Rails version: 6.0.1
RSpec version: 3.9
Observed behaviour
First...
then...
Expected behaviour
Obviously this is achieved by adding the following line to the Rails application config:
but I am curious—does the RSpec team consider this too much hand-holding? In my opinion, if it's not going to be provided automatically by the
rspec:install
generator, then it should at least be in the README.The text was updated successfully, but these errors were encountered: