Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double line issue on mobile browsers #194

Open
4unkur opened this issue Dec 7, 2017 · 1 comment
Open

Double line issue on mobile browsers #194

4unkur opened this issue Dec 7, 2017 · 1 comment

Comments

@4unkur
Copy link

4unkur commented Dec 7, 2017

There is an issue on mobile Chrome browser Xiaomi Redmi 4X

I've checked on iPhone 5s, HTC, Xiaomi Redmi Note 4X
and issue is happening only on Redmi 4X as I tested it on another Redmi 4X and WAS able to reproduce...

Sometimes another line appears, please see this GIF:

ezgif com-video-to-gif 1

@jmarikle
Copy link

jmarikle commented Jan 22, 2018

After some testing I think this issue is likely fixable by changing transform: rotate(3deg) translate(0px, -4px); to transform: rotate(3deg) translate3d(0px, -4px, 0); or by adding will-change: transform; to the #nprogress .peg style. This forces GPU rendering which fixes a lot of issues like this in webkit browsers. will-change is a fairly new addition to CSS that hints to the browser that certain changes are expected to occur, which allows the browser time to prepare for those changes ahead of time.

@rstacruz Do you accept pull requests for this sort of thing? I'd be happy yo make one. The potential fix is a very minor change to the CSS file.

Also, as a side note, since I'm already talking about the transform: rotate(3deg) translate(0px, -4px); bit of the CSS. Is there a reason translate(0px, -4px) was used instead of transform-origin: bottom right;?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants