Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests no longer pass with newest sklearn #65

Closed
jonringer opened this issue Jul 8, 2019 · 2 comments
Closed

Tests no longer pass with newest sklearn #65

jonringer opened this issue Jul 8, 2019 · 2 comments

Comments

@jonringer
Copy link

Running the tests with the scikit-learn v0.21.1 yields this result

======================================================================
ERROR: test_cv (__main__.TestEvolutionarySearch)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test.py", line 48, in test_cv
    try_with_params()
  File "test.py", line 40, in try_with_params
    cv = readme()
  File "test.py", line 32, in readme
    generations_number=5)
  File "/build/source/evolutionary_search/cv.py", line 297, in __init__
    error_score=error_score)
TypeError: __init__() got an unexpected keyword argument 'fit_params'

Indeed, they did remove this argument, as shown here:
scikit-learn/scikit-learn#13519

@rsteca
Copy link
Owner

rsteca commented Jul 8, 2019

Ok, thanks for the report, I'm going to check it out

@rsteca
Copy link
Owner

rsteca commented Jul 15, 2019

fixed

@rsteca rsteca closed this as completed Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants