Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doGlobalSearch() gives wrong result for tibbles #1044

Closed
mikmart opened this issue Jan 8, 2023 · 0 comments · Fixed by #1045
Closed

doGlobalSearch() gives wrong result for tibbles #1044

mikmart opened this issue Jan 8, 2023 · 0 comments · Fixed by #1045

Comments

@mikmart
Copy link
Contributor

mikmart commented Jan 8, 2023

doGlobalSearch() gives an incorrect result for tibble input data frames. This is likely due to the drop = FALSE default when subsetting tibbles.

tbl <- tibble::tibble(x = c("A", "B"))

# Incorrect
DT::doGlobalSearch(tbl, "B")
#> [1] 1

# Expected
DT::doGlobalSearch(as.data.frame(tbl), "B")
#> [1] 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant