Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_theme() should prefer curl #13

Closed
petrbouchal opened this issue Nov 20, 2016 · 3 comments
Closed

install_theme() should prefer curl #13

petrbouchal opened this issue Nov 20, 2016 · 3 comments
Milestone

Comments

@petrbouchal
Copy link

install_theme() fails when verifying github's certificate. This is probably a MacOS-specific issue related to the wget port. Could be resolved by changing how download.file() method is selected in download2() - to prefer curl over wget.

> install_theme('jbub/ghostwriter')
--2016-11-20 12:10:59--  https://github.com/jbub/ghostwriter/archive/master.zip
Resolving github.com (github.com)... 192.30.253.113, 192.30.253.112
Connecting to github.com (github.com)|192.30.253.113|:443... connected.
ERROR: cannot verify github.com's certificate, issued by ‘CN=DigiCert SHA2 Extended Validation Server CA,OU=www.digicert.com,O=DigiCert Inc,C=US’:
  Unable to locally verify the issuer's authority.
To connect to github.com insecurely, use `--no-check-certificate'.
Do not forget to change the 'theme' option in 'config.yaml' to "ghostwriter"
Warning messages:
1: In download.file(url, method = method, ...) :
  download had nonzero exit status
2: In utils::unzip(zipfile) : error 1 in extracting from zip file
@yihui yihui added this to the v0.1 milestone Nov 20, 2016
@yihui yihui closed this as completed in 5e5f8c0 Nov 20, 2016
@yihui
Copy link
Member

yihui commented Nov 20, 2016

Weird. I also have both wget and curl but wget works okay for me. Anyway, I just switched the order as you suggested. Thanks!

@petrbouchal
Copy link
Author

Thanks. I tried fixing but you were faster. Also, downloader might be a more elegant solution further down the road?

@yihui
Copy link
Member

yihui commented Nov 22, 2016

The download2 function in this package is simple enough and I guess it is not worth introducing a dependency. It has to be there due to a base R bug, and the person who introduced the bug promised to fix it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants