Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a host argument for install_theme()? #264

Closed
ijlyttle opened this issue Feb 24, 2018 · 1 comment · Fixed by #265
Closed

Consider a host argument for install_theme()? #264

ijlyttle opened this issue Feb 24, 2018 · 1 comment · Fixed by #265

Comments

@ijlyttle
Copy link
Contributor

I'd be happy to make a PR for this.

I have GitHub Enterprise (GHE) at work, and I have an ambition to produce a hugo theme for my company. I would like to be able to host this on our instance of GHE.

Further, I would like to offer a company-specific function acmetools::install_theme_acme() that would wrap blogdown::install_theme(), but it would require a host argument that might look something like:

install_theme <- function(theme, ..., host = "github.com"){
  ...
}

This way, I could design acmetools::install_theme_acme() to look like:

install_theme_acme <- function(theme, ..., host = "github.acme.com"){
  blogdown::install_theme(theme, ..., host = host)
}

What do you think?

If acceptable, perhaps new_site() could be adapted, as well? Others?

@yihui
Copy link
Member

yihui commented Feb 25, 2018

This definitely makes sense. Please go ahead and add a host argument to new_site() and install_theme().

I think it also makes sense to let the theme argument also accept a full URL (of the zip archive), but you can leave it to the future till someone really asks for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants