Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figures not being generated #31

Closed
ghost opened this issue Jan 14, 2017 · 3 comments
Closed

figures not being generated #31

ghost opened this issue Jan 14, 2017 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jan 14, 2017

I've recently come across blowdown after reading and searching for how to include htmlwidgets with jekyll+knitr to no avail.

I've been able to do a basic build using the instructions in the Readme.MD file, however I am struggling to understand why some charts don't end up with a figure being placed in the ../public/... folder.

The chart gets created in the ../blogdown/post/mypost_files/figure-html/ folder however they don't end up in at all in the ../public location.

I've got a repo here that hopefully demonstrates the issue at hand.

Let me know if you need any sessionInfo

@pdelboca
Copy link

Changing the name of the r chunk so it doesn't contain blank spaces solves the problem. From Rainfall chart to rainfall_chart should work ok.

I don't know why an image with a blank space doesn't work, it is created with the correct name and the html src has its %20 in the url. Maybe others can help understanding why it is failing with the whitespace.

@ghost
Copy link
Author

ghost commented Jan 14, 2017

That seems to have fixed the problem. I'll leave it open for now in case @yihui wants to look into this.

@yihui
Copy link
Member

yihui commented Jan 25, 2017

Yes, %20 is the culprit. Before I copy figures to public/, I should have restored the actual image paths from the encoded paths (a space is encoded as %20).

Before I come up with a fix, you will have to make sure the chunk labels contain no spaces.

@yihui yihui added the bug label Jan 26, 2017
@yihui yihui added this to the v0.1 milestone May 3, 2017
@yihui yihui closed this as completed in 143f0b7 May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants