Changes for upcoming htmlwidgets 1.6 release #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lytol
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming htmlwidgets 1.6 release happens to break the unit tests that check the class of
htmlwidgets::shinyWidgetOutput()(the new release will add some additional classes). Updating those expectations to useexpect_match()instead ofexpect_equal()will get them passing with the new release.Also, with htmlwidgets 1.6,
rsc*Output()now throws a warning because they return atagList()(which won't work for the newfillparameters). And since it seems like you don't need to usetagList()here and can instead just include the extra dependencies in the<div>, I made that change as well