ISO date format

[bergant]

Hi!

On windows (R version 3.0.2) I get only empty graph. After some debugging I am pretty sure it is because "my" format.POSIXct returns empty string when formated as "%F".

Maybe the asISO8601Time function in dygraphs/R/utils.R could be changed to

asISO8601Time <- function(x) {
  if (!inherits(x, "POSIXct"))
    x <- as.POSIXct(x)
  format(x, format="%Y-%m-%dT%H:%M:%SZ")
}

For now my workaround is:

res1 <- dygraph(nhtemp, main = "New Haven Temperatures",  ylab = "Temp (F)") 
res1$x$data[[1]] <- format( attr(res1$x, "time"), "%Y-%m-%dT%H:%M:%SZ")
res1

Dare

[jjallaire]

I am hesitant to mess with that function without knowing exactly what all the implications are (as I had trouble with date handling in JavaScript until the function was implemented as it currently is). It would also be helpful to have a full example and further explanation of the problem and your solution.

[bergant]

Example:

test1 <- xts( c(1, 2), as.POSIXct(c("2014-01-01", "2014-02-01"), tz = "GMT" ))
res1 <- dygraph(test1)
str(res1$x$data)

List of 2
 $ : chr [1:2] "" ""
 $ : num [1:2] 1 2

I think that changing

format(x, format="%FT%H:%M:%SZ", tz='GMT')

to

format(x, format="%Y-%m-%dT%H:%M:%SZ", tz='GMT')

should be just fine. Because %F should format date as %Y-%m-%d if implemented right
(as explained in R documentation). I think the problem is that %F is not implemented on windows platform (at least not in R version 3.0.2.).

[jjallaire]

Okay, I just committed that change to the format specification. Let me know if that resolves the issue on your end.

[bergant]

It's perfect now. Thanks.

test1 <- xts(c(1,2), as.POSIXct(c("2014-01-01", "2014-02-01"), tz = "GMT" ))
res1 <- dygraph(test1)
str(res1$x$data)

List of 2
 $ : chr [1:2] "2014-01-01T00:00:00Z" "2014-02-01T00:00:00Z"
 $ : num [1:2] 1 2

[ChipMart92]

Hi, bergant. This might be off topic, but I was hoping I could have your assistance with the XBRL files you posted Earlier. I was wondering how to apply this method to, say another company. Many thanks

[bergant]

@ChipMart92 I guess this has nothing to do with dygraphs. I have made my e-mail public on my account so you can contact me directly.