Make it possible to copy only the files listed in script/stylesheet/attachment of htmlDependency() #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttachment of htmlDependency() This is to provide a straightfoward solution to ramnathv/htmlwidgets#136, i.e. htmlDependency(all_files = FALSE)
yihui
added a commit
to yihui/htmlwidgets
that referenced
this pull request
Feb 7, 2016
Because otherwise it is impossible to cache code chunks that involve HTML widgets: the temp dir path changes between R sessions and gets deleted every time R quits, so the dependency object will not be reusable for the next R session Note this PR relies on rstudio/htmltools#48
|
LGTM. Nice improvement. @wch? |
|
Looks good to me too. |
yihui
added a commit
that referenced
this pull request
Feb 11, 2016
Make it possible to copy only the files listed in script/stylesheet/attachment of htmlDependency()
yihui
added a commit
to yihui/htmlwidgets
that referenced
this pull request
Feb 13, 2016
Because otherwise it is impossible to cache code chunks that involve HTML widgets: the temp dir path changes between R sessions and gets deleted every time R quits, so the dependency object will not be reusable for the next R session Note this PR relies on rstudio/htmltools#48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide a straightfoward solution to ramnathv/htmlwidgets#136, i.e.
htmlDependency(all_files = FALSE). And more importantly, make code chunks that contain HTML widgets cacheable in knitr. Currently they are not cacheable only because of the hack in htmlwidgets (copy the js binding to temp dir, and temp dir does not persist between R sessions).