Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for https://github.com/CliffCloud/Leaflet.EasyButton/ #295

Closed
wants to merge 2 commits into from
Closed

Support for https://github.com/CliffCloud/Leaflet.EasyButton/ #295

wants to merge 2 commits into from

Conversation

bhaskarvk
Copy link
Collaborator

@jcheng5 For review not for merging.

http://rpubs.com/bhaskarvk/easybutton

EasyButton plugin allows you to add custom actions to controllers. This is fairly straight forward but quite powerful.

@bhaskarvk bhaskarvk added type: enhancement Adds a new, backwards-compatible feature in progress labels Sep 18, 2016
@bhaskarvk bhaskarvk added this to the v1.1 milestone Sep 18, 2016
#' @export
addEasyButtonBar <- function(
map,
buttons,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make buttons a ... and get rid of easyButtonList altogether?

@jcheng5
Copy link
Member

jcheng5 commented Sep 21, 2016

Would prefer one help topic

@bhaskarvk
Copy link
Collaborator Author

Closing this one, preparing a new one as per discussion.

@bhaskarvk bhaskarvk closed this Sep 22, 2016
@bhaskarvk bhaskarvk deleted the feature/plugin-EasyButton branch September 22, 2016 17:22
@bhaskarvk bhaskarvk added duplicate Already catalogued invalid and removed in progress labels Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Already catalogued type: enhancement Adds a new, backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants