Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leaflet htmlwidget sizing policy exposed #548

Merged
merged 4 commits into from May 17, 2018
Merged

leaflet htmlwidget sizing policy exposed #548

merged 4 commits into from May 17, 2018

Conversation

schloerke
Copy link
Contributor

@schloerke schloerke commented May 15, 2018 •
edited

@tim-salabim

Does this address the sizing policy issue?

# if using github htmlwidgets
leaflet(
  sizingPolicy = leafletSizingPolicy(
    browser.external = TRUE, 
    viewer.suppress = TRUE
  )
) %>% 
  addTiles()

PR task list:

  • Update NEWS
  • Update documentation with devtools::document()

@tim-salabim
Copy link
Contributor

Yes, many thanks!

@schloerke schloerke requested a review from jcheng5 May 16, 2018 17:07
@schloerke schloerke merged commit a565b08 into rstudio:master May 17, 2018
@schloerke schloerke deleted the createWidget_args branch May 17, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schloerke @tim-salabim @jcheng5