Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flyTo and flyToBounds crash on leaflet initialization #552

Merged
merged 6 commits into from Jun 4, 2018
Merged

Fix flyTo and flyToBounds crash on leaflet initialization #552

merged 6 commits into from Jun 4, 2018

Conversation

schloerke
Copy link
Contributor

@schloerke schloerke commented May 24, 2018 •
edited

Fixes: #551

flyTo and flyToBounds was broken within leaflet.js as it had no initial location to fly from.

leaflet() %>% addTiles() %>% flyTo(-72, 42, 9)
leaflet() %>% addTiles() %>% flyToBounds(-72, 42, -72 + 1, 42 + 1)

PR task list:

  • Update NEWS

@schloerke schloerke requested a review from jcheng5 May 25, 2018 16:29
@schloerke schloerke mentioned this pull request May 25, 2018
Closed
@schloerke schloerke merged commit ea646ea into rstudio:master Jun 4, 2018
@schloerke schloerke deleted the flyTo branch June 4, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 Awaiting requested review from jcheng5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@schloerke