Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CRAN warnings #848

Merged
merged 1 commit into from Mar 9, 2023
Merged

Clean up CRAN warnings #848

merged 1 commit into from Mar 9, 2023

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Mar 9, 2023

Fixes CRAN warning:

checking S3 generic/method consistency ... WARNING
to_ring:
  function(x)
to_ring.Line:
  function(line)

to_ring:
  function(x)
to_ring.Polygon:
  function(pgon)

to_multipolygon_list:
  function(x)
to_multipolygon_list.SpatialPolygons:
  function(pgons)

to_multipolygon_list:
  function(x)
to_multipolygon_list.SpatialLines:
  function(lines)

to_multipolygon:
  function(x)
to_multipolygon.Polygons:
  function(pgons)

to_multipolygon:
  function(x)
to_multipolygon.Lines:
  function(lines)

See section ‘Generic functions and methods’ in the ‘Writing R
Extensions’ manual.

PR task list:

  • Update NEWS
  • Add tests (where appropriate)
    • R code tests: tests/testthat/
    • Visual tests: R/zzz_viztest.R
  • Update documentation with devtools::document()

@jcheng5
Copy link
Member Author

jcheng5 commented Mar 9, 2023

@schloerke @gadenbuie This is off the main branch, which contains #837, which we had previously said should wait for sf 1.0-10 to hit CRAN before we submit. So maybe this should be rebased to go off of our v2.1.1 tag? And then we have to remember to merge it into main as well.

@schloerke schloerke changed the base branch from main to rc-v2.1.2 March 9, 2023 19:41
@schloerke schloerke changed the base branch from rc-v2.1.2 to main March 9, 2023 19:41
@schloerke schloerke merged commit 3d98d0a into main Mar 9, 2023
@schloerke schloerke deleted the cran-warnings-2023-03 branch March 9, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants