Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how board_gdrive() uses dribble components #782

Merged
merged 5 commits into from Sep 8, 2023
Merged

Conversation

juliasilge
Copy link
Member

Closes #781

When I first put together the support for the Google Drive board, I did not pay enough attention to what is guaranteed to come in a dribble object:
https://googledrive.tidyverse.org/reference/dribble.html

This PR addresses this more holistically than #780, throughout all the methods. I don't think I want to change my general testing strategy, but I did just locally run through this (after running devtools::load_all()):

my_dribble <- googledrive::as_dribble("https://drive.google.com/drive/u/1/folders/1GQ-JuG4pT1AK9VLz9UZptnO73H7zDaUe")
board <- board_gdrive(my_dribble)
test_api_basic(board)
test_api_versioning(board)
test_api_meta(board)

All these tests pass and I expect this to now work much better.

@juliasilge juliasilge marked this pull request as ready for review September 7, 2023 03:00
@juliasilge juliasilge merged commit bb49622 into main Sep 8, 2023
14 checks passed
@juliasilge juliasilge deleted the fix-gdrive-dribble branch September 8, 2023 20:14
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path does not exist errors related to pin_versions in gdrive
1 participant