update doc R6, fix docs check #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Jun 8, 2020
schloerke
reviewed
Jun 8, 2020
schloerke
reviewed
Jun 8, 2020
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
schloerke
reviewed
Jun 8, 2020
We need to keep them for historical reasons. They can be minimally documented. Can we add a |
|
I'll let you go through this and I'll circle around later. |
schloerke
reviewed
Jun 8, 2020
schloerke
reviewed
Jun 8, 2020
schloerke
reviewed
Jun 8, 2020
schloerke
requested changes
Jun 8, 2020
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
Co-authored-by: Barret Schloerke <barret@rstudio.com>
schloerke
approved these changes
Jun 10, 2020
cpsievert
approved these changes
Jun 10, 2020
This was referenced Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #522
updated documentation on R6 class
fix doc link for sodium random -> helpers
added custom swagger spec examples
comments welcome
mental check list:
remove deprecated plumber methods? or mark for deletion
should we add more documentation to initialize of PlumberEndpoint and PlumberStep?
should they even be exported? Maybe for historical reason.
PR task list:
devtools::document()