-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vars()
seems required for rows_*()
but not other functions
#416
Comments
maybe related to #414 |
vars()
seems required for rows_distinct()
but not other functionsvars()
seems required for rows_*()
but not other functions
Thanks for submitting this issue and the previous one! Agree that it’s inconsistent and I should be able to address this soon. |
I think I noticed that the |
Thanks @Aariq , I made a new issue to track this. Eventually I do want to get all these column/value inconsistencies fixed up. Maybe off topic a bit but the place where things are non-ideal is in the |
Since For all expectations |
Thanks for the patience! This is now supported in devel. agent <-
create_agent(
tbl = small_table
)
x1 <- agent %>%
rows_distinct(vars(a))
x2 <- agent %>%
rows_distinct(c(a))
waldo::compare(x1, x2)
#> `old$validation_set$columns_expr`: "vars(a)"
#> `new$validation_set$columns_expr`: "c(a)"
x3 <- agent %>%
rows_complete(vars(a))
x4 <- agent %>%
rows_complete(c(a))
waldo::compare(x3, x4)
#> `old$validation_set$columns_expr`: "vars(a)"
#> `new$validation_set$columns_expr`: "c(a)" We now encourage using |
Prework
Description
Not entirely sure this is a bug, but it is inconsistent. The examples for
pointblank
usevars()
to select columns, but it seems likec()
works identically for most functions exceptrows_distinct()
androws_complete()
.Reproducible example
Created on 2022-06-16 by the reprex package (v2.0.1)
Session info
Expected result
I would have expected either
vars()
orc()
to work in thecolumns
argument forrows_distinct()
as either one works for many other functions inpointblank
.The text was updated successfully, but these errors were encountered: