Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling in the tidyverse #102

Closed
wlandau opened this issue Nov 4, 2018 · 4 comments · Fixed by #118
Closed

Profiling in the tidyverse #102

wlandau opened this issue Nov 4, 2018 · 4 comments · Fixed by #118

Comments

@wlandau
Copy link

wlandau commented Nov 4, 2018

I find it difficult to read profvis output when I use tidyverse functions. Is there a way to hide superfluous parts of the call stack?

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union

# dplyr
profvis::profvis({
  d <- data.frame(x = rnorm(1e7))
  d <- mutate(d, y = rnorm(1e7))
  d <- mutate(d, z = rnorm(1e7))
})

# magrittr
profvis::profvis({
  data.frame(x = rnorm(1e7)) %>%
    cbind(y = rnorm(1e7)) %>%
    cbind(z = rnorm(1e7))
})

# base
profvis::profvis({
  d <- data.frame(x = rnorm(1e7))
  d$y <- rnorm(1e7)
  d$z <- rnorm(1e7)
})

Created on 2018-11-04 by the reprex package (v0.2.1)

@wch
Copy link
Member

wch commented Nov 5, 2018

cc @hadley @jimhester @lionel-

@hadley
Copy link
Member

hadley commented Nov 5, 2018

The dplyr issue should be resolved in the dev version; the magrittr version might one day be resolved if we rework how the pipe works.

@sanjmeh
Copy link

sanjmeh commented Sep 3, 2019

Gentlemen, was there any movement on this issue? There is a similar issue on stack overflow where profvis() is not able to remove internal calls from shinyapp profiling as well.
https://stackoverflow.com/questions/57776408/how-to-hide-internal-function-calls-in-profvis-flame-graph-running-on-a-shinya
I am presuming these two issues are related.
Looking forward to a solution.

@lionel-
Copy link
Member

lionel- commented Sep 3, 2019

The patch is pending review https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants