Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling to line does not work in Firefox #111

Closed
wch opened this issue Jun 27, 2019 · 0 comments · Fixed by #113
Closed

Scrolling to line does not work in Firefox #111

wch opened this issue Jun 27, 2019 · 0 comments · Fixed by #113

Comments

@wch
Copy link
Member

wch commented Jun 27, 2019

With the example below, when the output is viewed in Firefox, hovering over a block in the flame graph does not cause it to scroll to the corresponding line.

library(profvis)
profvis({
    f <- function() {
      pause(1)
    }

    
    
    
    
    
    
    
    
    
    
    
    
   
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    
    f()
})
@wch wch closed this as completed in #113 Jul 12, 2019
wch added a commit that referenced this issue Jul 12, 2019
* Update scrollIntoViewIfNeeded for Firefox. Closes #111

* Move scrollIntoViewIfNeeded polyfill to separate file

* Update NEWS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant