Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes should be grouped in "super nodes" that can expand and collapse #55

Open
schloerke opened this issue Aug 24, 2019 · 0 comments
Open

Comments

@schloerke
Copy link
Collaborator

Things like renderPlot should not create 5 nodes on the screen by default. Instead, it should be one super node that contains all 5 nodes.

Super nodes should:

  • Be able to expand and show contents
  • Be able to collapse to hide contents
  • Have any outside parent nodes be parents
  • Have any downstream children be children

In the case of a deduper where

deduper <- function(x, label) {
  res <- reactiveVal(x, label = label, node_group = "deduper")
  observe(label = "obs_x", node_group = "deduper", {
    res(x())
  })
  res
}
y <- deduper(x, label = "y")

where it would show graph

x -> deduper -> y -> etc

and not graph

x -> obs_x
y -> etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant