fix import asyncio on Windows in RStudio
#1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyncio.windows_utils subclasses/aliases Popen like this:
```python
class Popen(subprocess.Popen)
def __init__(...):
...
try:
super().__init__(...)
...
```
Calling `partial()` on Popen directly works when
using it like a function, but breaks when
subclassing Popen (like asyncio does).
Closes rstudio/keras#1375
Closes #1478
t-kalinowski
force-pushed
the
fix-popen-redux
branch
from
9c34d2f
to
42fc525
Compare
t-kalinowski
changed the title
Popen.__init__, not Popenimport asyncio on Windows in RStudio
t-kalinowski
added a commit
that referenced
this pull request
Sep 18, 2023
t-kalinowski
added a commit
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio.windows_utils subclasses/aliases
subprocess.Popenlike this:Calling
partial()onPopendirectly works whenusing it like a function, but breaks when
subclassing Popen (like asyncio does).
This means that any modules that attempt to import asyncio on windows will
fail as well, like tensorflow.
Closes rstudio/keras#1375 Closes #1478