Fix issue with unsorted indices in csc_matrix #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rix as well Co-authored-by: Kai Waldrant <kai@data-intuitive.com>
Co-authored-by: Kai Waldrant <kai@data-intuitive.com>
|
@rcannood Thank you for the PR, this looks great. Would you like to add a NEWS entry? |
|
Done! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves an issue with converting csc matrices with unsorted indices, similar to #727.
In https://github.com/rcannood/reticulate/pull/1, the CI checks fails for the first commit (in which I added a test to detect this problem), but the CI checks succeed for the second commit (in which I added the fix).