prefer 'agg' for non-interactive R #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/knitr-engine.R
Outdated
| # in RStudio Desktop, enforce a non-Qt matplotlib backend | ||
| # this is especially important with RStudio Desktop as attempting to use a Qt | ||
| # backend will cause issues due to mismatched Qt versions between RStudio and | ||
| # Anaconda environments, and will cause crashes when generating plots |
There was a problem hiding this comment.
Is this a conda specific workaround? Would a venv python installation find the same Qt version as the IDE? If not, should the comment be updated?
There was a problem hiding this comment.
IIRC, this branch was specifically required for older versions of RStudio (which were built against Qt); I've updated the comment to indicate that and also note that we could probably remove this in a future reticulate release. Does that seem sensible?
|
Sorry I missed this on Monday. Looks good thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rstudio/rstudio#13840.
@cderv does this look like the right fix to you?