Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support array in chalkboard reveal_options #88

Merged
merged 11 commits into from
Sep 16, 2021

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Jun 10, 2021

This PR fixes #62 by transforming character vector into an array represented by a bracketed string.

@atusy
Copy link
Contributor Author

atusy commented Jun 10, 2021

Oops, this is not enough. In some case, we need brackets even if length 1.

@atusy
Copy link
Contributor Author

atusy commented Jun 10, 2021

I improved handling of array requirements based on my reviewing JavaScript codes from chalkboard and menu.

FYI: when chalkboard theme is white, only first value of the color is available according to

draw = [ drawWithPen , drawWithPen ];

@cderv cderv self-requested a review September 16, 2021 10:27
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atusy !

I tweaked a bit to stay focus on the fix.

I think I'll rethink the whole handling of reveal options.

There is now a quoting thing to handle and the current fix I have made is maybe not the right solution.

Anyway, this correct fix #62

@cderv
Copy link
Collaborator

cderv commented Sep 16, 2021

Tested with

---
title: "Test"
output: 
  revealjs::revealjs_presentation:
    self_contained: false
    reveal_plugins: ["chalkboard"]
    reveal_options:
      chalkboard:
        theme: whiteboard
        color: ['rgba(255, 0, 0, 0.3)', 'rgba(255, 0, 0, 0.3)']
    keep_md: true
---

# Slide 1

Test

* test
* test
* test

# Slide 2

more text

## subslide 1

even more text

@cderv cderv changed the title support array in reveal_options (closes #62) support array in chalkboard reveal_options Sep 16, 2021
@cderv cderv merged commit 0e3a0d3 into rstudio:master Sep 16, 2021
@atusy
Copy link
Contributor Author

atusy commented Sep 16, 2021

Great! Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the pen color of the chalkboard plugin of reveal.js in RStudio
2 participants