Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep uppercase for tocify's hash (fix #975) #1783

Merged
merged 3 commits into from Mar 9, 2020
Merged

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Mar 9, 2020

This PR fixes #975

For floating TOC, custom hashGenerator is defined by 5b98ee1 .
There, .toLower() is introduced, which made "Foo" and "foo" indistinctive.
I fixed the problem by removing .toLower().

reprex

---
title: title
output:
  html_document:
    toc: true
    toc_float: true
---

# foo

```{r}
iris
```

# Foo

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thank you!

@yihui yihui merged commit 947b872 into rstudio:master Mar 9, 2020
sthagen added a commit to sthagen/rstudio-rmarkdown that referenced this pull request Mar 12, 2020
fix rstudio#975: keep uppercase for tocify's hash (rstudio#1783)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOC doesn't work with duplicate names and different capitalizations
2 participants