Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enrich documentation of output_format_dependency #2508

Merged
merged 5 commits into from Sep 5, 2023

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Sep 4, 2023

This PR adds an missing document that guides how to merge a dependency.

BTW, I think it is a good idea to add a practical usage (like the one in #2507) on the function document or somewhere else (maybe R Markdown Cookbook?).
Do you have any suggestions?

@cderv
Copy link
Collaborator

cderv commented Sep 4, 2023

BTW, I think it is a good idea to add a practical usage (like the one in #2507) on the function document or somewhere else (maybe R Markdown Cookbook?).

Yes R Markdown cookbook seems to me like a right place. You could also write a blog post (or add to existing one) this example, and we could link from help page too 🤷‍♂️ Just that blog post is usually a good place for examples.

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

R/output_format.R Outdated Show resolved Hide resolved
atusy and others added 2 commits September 6, 2023 01:28
Co-authored-by: Yihui Xie <xie@yihui.name>
@yihui yihui merged commit 8d2d9b8 into rstudio:main Sep 5, 2023
17 checks passed
@atusy
Copy link
Contributor Author

atusy commented Sep 6, 2023

@cderv @yihui

Thank you for the review.
About the documentation, I'd be happy to contribute R Markdown Cookbook.
Just for now, I added the example in the previous blog post.
https://blog.atusy.net/2023/08/28/rmarkdown-output-format-dependency/

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants