Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant wording in Pane Layout options #10213

Open
3 of 4 tasks
mine-cetinkaya-rundel opened this issue Dec 9, 2021 · 3 comments
Open
3 of 4 tasks

Redundant wording in Pane Layout options #10213

mine-cetinkaya-rundel opened this issue Dec 9, 2021 · 3 comments
Labels
bug layout Issues relating to layout, appearance, pane organization, etc.
Milestone
Later

Comments

@mine-cetinkaya-rundel
Copy link

mine-cetinkaya-rundel commented Dec 9, 2021 •
edited
Loading

System details

RStudio Edition : Desktop
RStudio Version : RStudio 2022.01.0-daily+290 "Prairie Trillium" Daily (5584871710f8df9db57af3e0bb31cf85f8f6d7f5, 2021-12-07) for macOS

Mozilla/5.0 (Macintosh; Intel Mac OS X 12_0_1) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/5.12.10 Chrome/69.0.3497.128 Safari/537.36
OS Version : macOS 12.0.1
R Version : 4.1.2

Steps to reproduce the problem

  • Go to RStudio > Preference > Pane layout
  • Click on the name of the pane starting with Environment to expand the description

Describe the problem in detail

It says "Presentations, Presentation", which is redundant

pane-layout

Describe the behavior you expected

It should say just "Presentation"

  • I have read the guide for submitting good bug reports.
  • I have installed the latest version of RStudio, and confirmed that the issue still persists.
  • If I am reporting an RStudio crash, I have included a diagnostics report.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
@ronblum ronblum added bug layout Issues relating to layout, appearance, pane organization, etc. labels Dec 10, 2021
@ronblum ronblum added this to the Spotted Wakerobin (2022.06.0) milestone Dec 10, 2021
@ronblum ronblum added the triage label Dec 10, 2021
@romainfrancois romainfrancois self-assigned this Dec 15, 2021
@romainfrancois romainfrancois mentioned this issue Dec 15, 2021
Merged
4 tasks
@ronblum
Copy link
Contributor

ronblum commented Jan 18, 2022

Note: See the reversion at #10250 and #10367 (comment)

@R-Hannibal R-Hannibal self-assigned this Jan 21, 2022
@R-Hannibal
Copy link

Just carrying over the info from the linked issue (thank you @ronblum for connecting the tickets), the fix here caused a regression in pane layout functionality and has been reverted.

The proposed solution which has several upvotes and I also think is a good suggestion, is to clearly distinguish between the 2 labels by naming something more distinct like R Presentations and Quarto Presentations.

Moving this from test to backlog and bouncing to the Spotted Wakerobin milestone.

@R-Hannibal R-Hannibal added backlog and removed test labels Jan 21, 2022
@R-Hannibal R-Hannibal removed their assignment Jan 21, 2022
@romainfrancois romainfrancois removed their assignment Jan 21, 2022
@romainfrancois romainfrancois self-assigned this Feb 15, 2022
@romainfrancois
Copy link
Contributor

I'm going to give this one out because I don't really understand what is happening in PaneConfig.java and the special nature of "Presentation".

@romainfrancois romainfrancois removed their assignment Apr 21, 2022
@mikebessuille mikebessuille modified the milestones: 2023, 2024 Jul 4, 2022
@ronblum ronblum modified the milestones: Backlog-3, Later Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug layout Issues relating to layout, appearance, pane organization, etc.
Projects
None yet
Milestone
Later
Development

No branches or pull requests
6 participants
@kevinushey @romainfrancois @mine-cetinkaya-rundel @mikebessuille @ronblum @R-Hannibal