Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native file and message dialogs on Linux desktop #14683

Open
gtritchie opened this issue May 9, 2024 · 4 comments
Open

Use native file and message dialogs on Linux desktop #14683

gtritchie opened this issue May 9, 2024 · 4 comments

Comments

@gtritchie
Copy link
Member

The long-standing issue of Electron showing the file and message dialogs behind the main window has been fixed and should appear in an upcoming Electron release.

electron/electron#32857

We worked around this bug on Linux by adding an option to use the web-based dialogs (same as RStudio Server) and turned it on by default only on Linux: #11184

Once we've confirmed the fix is in the version of Electron we're using, we should consider changing the default for Linux (and possibly discuss if we should ditch this option to use web-based dialogs on Desktop altogether to simplify the testing matrix).

@ronblum
Copy link
Contributor

ronblum commented May 10, 2024

^ ignore that "mentioned this issue"--that was a typo, wrong issue.

@ronblum ronblum removed the new New incoming issues, ready for initial review. label May 10, 2024
@ronblum ronblum added this to the Cranberry Hibiscus milestone May 15, 2024
@ronblum
Copy link
Contributor

ronblum commented May 15, 2024

Note: The non-native dialogs are needed for automated testing.

@gtritchie gtritchie self-assigned this May 15, 2024
@gtritchie
Copy link
Member Author

Confirmed the electron fix is in the build we are using, so this work item is ready to go.

@gtritchie
Copy link
Member Author

gtritchie commented Jun 3, 2024

One slight concern, when I tried this on Ubuntu 22, the File Open dialog now has an "Open read-only" checkbox; we need to see if we can suppress this as it may be confusing for users.

screenshot of open file dialog on Ubuntu 22 highlighting the read-only checkbox

I opened electron/electron#42349 against Electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants