-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsession hangs, pegs CPU on close #5222
Comments
I saw this over the weekend (I had 4 or 5 rsessions sticking around and the fans were... whirring). Was going to open an issue next time I got in that state but now I don't have to. |
I haven't seen this in a while on the v1.3 branch, so I think this may indeed be fixed. |
I'll install the latest beta in a bit but I'm on one of them from this week and this is definitely still happening. CPU pegged (Activity says RStudio is the problem). Close RStudio. rsession hangs around and it now does the pegging. I mean, it's almost winter so a warm laptop is nice but… ;-) |
A reproducible example, or a stack trace (e.g. recorded through Instruments) could be helpful. |
Cool. I'll setup a test this weekend.
… On Nov 22, 2019, at 13:21, Kevin Ushey ***@***.***> wrote:
A reproducible example, or a stack trace (e.g. recorded through Instruments) could be helpful.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I just hit this (dev build, macOS, latest master)! Fans were getting excited, and sure enough had a rogue rsession. Attached to it, and here's the stack on each thread. @jmcphers, might be something related to preferences at session shutdown? Debugger immediately breaks on: Main Thread
Thread 2
Thread 3
Thread 4
Thread 5 (for completeness)
|
That rsession might have been hanging around a while, lldb console errors:
|
FWIW my solution for a similar monitor-related crash was this: rstudio/src/cpp/session/SessionMain.cpp Lines 1222 to 1227 in 9252546
Not sure if there's another more appropriate place to force the monitor to be stopped? |
System details
Steps to reproduce the problem
Try to close a project (e.g. either explicitly closing it, or switching to a new project).
Describe the problem in detail
On occasion, the project fails to close. If Activity Monitor is opened, one sees an
rsession
pegging two CPUs (200% CPU usage).Describe the behavior you expected
Close without issue.
Notes
Looks like the File Monitor is getting stuck while trying to deregister:
Perhaps the main thread + file monitor threads are attempting to close the same handle at the same time, and getting stuck?
The text was updated successfully, but these errors were encountered: