Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let keyboard focus consistently follow switch pane keyboard shortcuts #5652

Open
maxheld83 opened this issue Oct 29, 2019 · 12 comments
Open

Comments

@maxheld83
Copy link

maxheld83 commented Oct 29, 2019

Observed behavior:

  1. I have, say, the console in focus.
  2. I hit the keyboard shortcut to "show build pane"
  3. I use the arrow key to navigate (a typically pretty long) build pane.
    None of then nav keys work to navigate the build log. The keyboard focus actually stays inside the console..

Now for the inconsistencies:

  • If, in addition, I click into the build log, I can navigate it with the nav keys as expected.
  • If I navigate from the console to the help or packages pane via keyboard shortcut "show help pane" I have focus and can use the nav keys.
  • I can never get cursor focus (for nav keys) for the files pane, no matter how I switch into it.

I think it would be super cool if I could use nav keys inside other (long) panes, too, irrespective of how I switched to them.
Build logs, in particular, need to be perused quite frequently, and they tend to be quite long.
My assumption as a user was actually that whenever I "show pane" something, it should also have focus.

Not quite sure whether this is a bug report or feature request; could be either, depending on what the intended capabilities of RStudio are.

RStudio Edition : Desktop
RStudio Version : 1.2.5013
OS Version : macOS 10.14.6
R Version : 3.6.1

@gtritchie gtritchie added this to the v1.3 milestone Oct 29, 2019
@gtritchie gtritchie changed the title let cursor focus consistently follow switch pane keyboard shortcuts let keyboard focus consistently follow switch pane keyboard shortcuts Oct 29, 2019
@gtritchie
Copy link
Member

Thanks for the report! We are working on these sorts of issues in the RStudio 1.3 release as part of overall accessibility improvements.

@gtritchie
Copy link
Member

Moving out of 1.3; I am fixing these pane-by-pane (probably not all the panes for 1.3); in 1.4 hope to make a more general set of focus handling fixes.

@hrbrmstr
Copy link
Contributor

Not sure if this is somewhere else, but if I'm in a package project and am in a source pane and then key-shortcut build the pkg, it'd be super less frustrating to have the focus stay in the source pane.

@gtritchie
Copy link
Member

gtritchie commented Feb 28, 2020

Not sure if this is somewhere else, but if I'm in a package project and am in a source pane and then key-shortcut build the pkg, it'd be super less frustrating to have the focus stay in the source pane.

Worth having its own issue, there will be cases like this I want to be aware of as I make overall keyboard focus improvements. Thanks!

@gtritchie
Copy link
Member

I consider this a stretch goal for 1.4. It is very critical for keyboard and/or screen-reader users, but fixing this across the board is probably not going to happen given the code complexity. Most likely will end up breaking this into some much more targeted fixes for specific scenarios in 1.4 (like, 3 or 4 panes at most).

@hrbrmstr
Copy link
Contributor

hrbrmstr commented Jul 6, 2020 via email

@gtritchie
Copy link
Member

... On the plus side, I'm getting much better at automatically hitting ctrl-1 after certain ops :-)

Yah. It is painful for a keyboard only user for sure. Will make some selective improvements, hopefully, or discover a previously unknown cache of caffeine and/or time travel and get the whole thing fixed.

@hrbrmstr
Copy link
Contributor

hrbrmstr commented Jul 6, 2020

Whatever I can do to help test/triage just lemme know.

@gtritchie
Copy link
Member

Moving out of 1.4 (sigh), may selectively pull in some more specific fixes to 1.4 if time permits.

@gtritchie gtritchie removed this from the v1.4 milestone Jul 8, 2020
@gtritchie gtritchie moved this from To do to Review in Accessibility (Open Source 1.4) Jul 8, 2020
@hrbrmstr
Copy link
Contributor

hrbrmstr commented Jul 9, 2020 via email

@stale
Copy link

stale bot commented Feb 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

@stale stale bot added the stale Issues which have been closed automatically due to inactivitiy. label Feb 5, 2021
@gtritchie
Copy link
Member

Important for keyboard-only users.

@stale stale bot removed the stale Issues which have been closed automatically due to inactivitiy. label Feb 5, 2021
@gtritchie gtritchie added this to the v1.6 milestone Feb 5, 2021
@mikebessuille mikebessuille modified the milestones: Future-4, Later Oct 31, 2022
@gtritchie gtritchie removed their assignment Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants