Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily build: filtering citations does not filter adequately #7719

Closed
4 tasks done
florisvdh opened this issue Sep 3, 2020 · 2 comments
Closed
4 tasks done

Daily build: filtering citations does not filter adequately #7719

florisvdh opened this issue Sep 3, 2020 · 2 comments
Assignees
Labels
visual markdown For bugs related to the new visual editor mode added for RMarkdown docs in the 1.4 release.
Milestone

Comments

@florisvdh
Copy link

System details

RStudio Edition : Desktop
RStudio Version : 1.4.774
OS Version : Linux Mint 20 (~Ubuntu 20.04)
R Version : 4.0.2

Steps to reproduce the problem

  1. Visual markdown editor: press ctrl+shift+F8
  2. In the dialog box, go to a Zotero collection
  3. In the 'search for citation field', type an author's name which should be rather unique in the Zotero DB.

Describe the problem in detail

Still many records are shown after filtering. It may be that individual letters are being searched for, not words.

Describe the behavior you expected

When entering a word which is unique in the database, only one record should remain.

@jjallaire jjallaire added the visual markdown For bugs related to the new visual editor mode added for RMarkdown docs in the 1.4 release. label Sep 5, 2020
@jjallaire jjallaire added this to the v1.4 milestone Sep 5, 2020
@dragonstyle
Copy link
Contributor

Thanks for reporting this. We are using approximate string matching for our search which won't result in unique/exact matching, but instead perform a weighted fuzzy search on Citekey, Author, Title, Publication, and Issue Date. If your search becomes unique enough, its possible that all the results but one will disappear, but typically I would expect there to be many matches, but sorted properly (e.g. the first item should be a great match).

If you're not seeing this, please do let me know as I can fine tune the approximation behavior and weighting and would be happy to do so to improve the search quality.

@florisvdh
Copy link
Author

👍 I can confirm that entries are properly sorted (in 1.4.823).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual markdown For bugs related to the new visual editor mode added for RMarkdown docs in the 1.4 release.
Projects
None yet
Development

No branches or pull requests

8 participants