Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command palette sluggish with JAWS screen reader #7869

Open
4 tasks done
gtritchie opened this issue Sep 23, 2020 · 3 comments
Open
4 tasks done

Command palette sluggish with JAWS screen reader #7869

gtritchie opened this issue Sep 23, 2020 · 3 comments

Comments

@gtritchie
Copy link
Member

System details

RStudio Edition : Server
RStudio Version : 1.4.861
OS Version      : Windows
R Version       : any

Steps to reproduce the problem

  • Start JAWS 2020
  • Load RStudio Server session in Chrome
  • Invoke command palette (Ctrl+Shift+P)
  • Use down arrow to step through the commands

Describe the problem in detail

  • There is a long delay (~4 seconds) before each item is announced

Describe the behavior you expected

  • Moving between items should be relatively instantaneous
  • It is much better with NVDA or Windows Narrator
  • Performance improves if you type something and filter the list to be shorter

Note, during development we tried a variety of approaches to improving this, with little success.

  • I have read the guide for submitting good bug reports.
  • I have installed the latest version of RStudio, and confirmed that the issue still persists.
  • If I am reporting a RStudio crash, I have included a diagnostics report.
  • I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
@jmcphers
Copy link
Member

jmcphers commented Sep 23, 2020

Most of our experiments were around explicitly telling screen readers, via various ARIA attributes, how many commands were in the list and the index of each command.

I suspect that we could solve this by ensuring that the list of commands in the DOM remains short (as @gtritchie notes, a short list of commands in the DOM demonstrably improves performance). For example, we could avoid showing any commands until you've typed something (behavior that many other command palettes have), and only show the first 20 matches for a search.

@stale
Copy link

stale bot commented Feb 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, per https://github.com/rstudio/rstudio/wiki/Issue-Grooming. Thank you for your contributions.

@stale stale bot added the stale Issues which have been closed automatically due to inactivitiy. label Feb 4, 2021
@gtritchie
Copy link
Member Author

This is an important accessibility issue to tackle in the future as the command-palette is an important part of keyboard-only use for screen-reader users. Adding to v1.6 milestone.

@stale stale bot removed the stale Issues which have been closed automatically due to inactivitiy. label Feb 4, 2021
@gtritchie gtritchie added this to the v1.6 milestone Feb 4, 2021
@mikebessuille mikebessuille modified the milestones: Future-4, Later Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants